Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: use vitest to make unitest #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cexbrayat merged 27 commits into vuejs:main from CoolPlayLin:CoolPlayLin/vitest
Nov 25, 2023
Merged

Conversation

Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Nov 12, 2023 •
edited
Loading

@CoolPlayLin CoolPlayLin marked this pull request as ready for review November 18, 2023 10:10
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, just a few names to change and we'll be OK to merge

 

delete unnecessary empty line in getCommand.spec.ts
delete unnecessary tests
rename some tests
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the PR @CoolPlayLin 👍

CoolPlayLin reacted with hooray emoji
Copy link
Member

Oh it looks like the PR needs to be rebased on main. Can you do that please?
CoolPlayLin reacted with thumbs up emoji

Copy link
Contributor Author

CoolPlayLin commented Nov 25, 2023 •
edited
Loading

done @cexbrayat

cexbrayat reacted with heart emoji

@cexbrayat cexbrayat merged commit 8b6c2cd into vuejs:main Nov 25, 2023
@CoolPlayLin CoolPlayLin deleted the CoolPlayLin/vitest branch November 25, 2023 09:57
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use vitest to make unittest

AltStyle によって変換されたページ (->オリジナル) /