-
Notifications
You must be signed in to change notification settings - Fork 497
feat: i18n solution for prompts messages #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ci test is blocked because of this:
1695653758469
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've been thinking about this feature for a while.
However, I don't think it should be an additional option. Many people don't wanna bother selecting one at all.
Please make it implicit by reading the user's language setting from the environment variables.
Thanks! I've been thinking about this feature for a while. However, I don't think it should be an additional option. Many people don't wanna bother selecting one at all.
Please make it implicit by reading the user's language setting from the environment variables.
No problem, already updated. Is there anything that needs improvement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks really good.
Straightforward i18n solution for prompts messages