-
Notifications
You must be signed in to change notification settings - Fork 496
feat: add Nightwatch for end-to-end testing #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9f15b3c to
ceee3c1
Compare
(削除) I wonder why the tests are failing in CI; locally, the tests are passing. (削除ここまで)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be changed to .dom.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Thanks! The templates look pretty good to me now.
However, I still need some more time to play with it a little bit more because of the complexity.
So I'd like to cut one more release of create-vue before merging this one.
I plan to ship this feature with the coming update to Vue 3.3, or soon after if the testing takes longer.
Hi @sodatea, I was wondering if there are any updates I need to make to this PR for it to be merged.
As far as I've tested, the changes are good.
The only concern is the implicit hard dependency on the jsx option, because the jsx plugin is used in the new vite.config.js. We want JSX support to be optional.
To fix that issue, we need some kind of logical composition for vite.config.js templates, so that the templates can handle more complex scenarios.
But I think that deserves another PR, and I'm merging this one now.
The base template has an `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to write the template again, though. This fixes the issue mentioned in #257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
The base template has a `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to define the template again, though. This fixes the issue mentioned in #257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
The base template has a `vite.config.js.ejs` template file, which reads data from a corresponding `vite.config.js.data.mjs` file. The data file has a default export called `getData()`. Other templates can also have data files that can be chained together so that they can modify the data fed into the template. They don't have to define the template again, though. This fixes the issue mentioned in vuejs/create-vue#257 (comment) As we don't support plugins or extensions for this tool, I didn't choose to design the feature in an extensible way, but only considered ease of implementation and ease of modification.
Hello 👋 ,
This PR integrates
nightwatchas an end-to-end testing solution for the create-vue CLI. With this integration, developers can quickly write and run automated tests for their Vue applications using the popular nightwatch testing framework.Thank you
cc @sodatea