-
Notifications
You must be signed in to change notification settings - Fork 497
Update base.css #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base.css #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate why this change is necessary?
Could you elaborate why this change is necessary?
In some third-party dependencies (e.g. monaco-editor), the offsets of some positioned elements are not relative to their parent nodes but their ancestor nodes, cuz their parent nodes have no position attribute. Therefor, the original code may lead to certain unexpected offsets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
But this change breaks the styles of the landing page. We need to fix that before removing the global reset.
No description provided.