-
-
Notifications
You must be signed in to change notification settings - Fork 9k
fix(Transition): ensure appear callback invoking properly #9412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@edison1105
edison1105
changed the title
(削除) fix(Transition): ensure remove appear class in enter callbacks (削除ここまで)
(追記) fix(Transition): ensure appear callback invoking properly (追記ここまで)
Oct 18, 2023
@edison1105
edison1105
added
🐞 bug
Something isn't working
scope: transition
ready for review
This PR requires more reviews
labels
Sep 3, 2024
@vue/compiler-core
pnpm add https://pkg.pr.new/@vue/compiler-core@9412
@vue/compiler-dom
pnpm add https://pkg.pr.new/@vue/compiler-dom@9412
@vue/compiler-sfc
pnpm add https://pkg.pr.new/@vue/compiler-sfc@9412
@vue/reactivity
pnpm add https://pkg.pr.new/@vue/reactivity@9412
@vue/runtime-core
pnpm add https://pkg.pr.new/@vue/runtime-core@9412
@vue/compiler-ssr
pnpm add https://pkg.pr.new/@vue/compiler-ssr@9412
@vue/runtime-dom
pnpm add https://pkg.pr.new/@vue/runtime-dom@9412
@vue/server-renderer
pnpm add https://pkg.pr.new/@vue/server-renderer@9412
@vue/shared
pnpm add https://pkg.pr.new/@vue/shared@9412
vue
pnpm add https://pkg.pr.new/vue@9412
@vue/compat
pnpm add https://pkg.pr.new/@vue/compat@9412
commit: b2b5ffc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
close #9396
The root cause is that the
transitionendcallback of enterHook corresponding toonAppearis not invoked. Becauseel._endIdis updated byonEnter