-
-
Notifications
You must be signed in to change notification settings - Fork 9k
fix(runtime-core): avoid number type transition child key duplicating with index key #5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@yuwu9145
yuwu9145
force-pushed
the
fix-5762
branch
2 times, most recently
from
April 22, 2022 04:52
45830e3 to
74cddb5
Compare
@yuwu9145
yuwu9145
changed the title
(削除) fix(runtime-core): respect child index position in transition group w... (削除ここまで)
(追記) fix(runtime-core): respect child index position when calculating key (追記ここまで)
Apr 22, 2022
@yuwu9145
yuwu9145
force-pushed
the
fix-5762
branch
2 times, most recently
from
April 22, 2022 11:24
7e530b5 to
9f4facb
Compare
@yuwu9145
yuwu9145
changed the title
(削除) fix(runtime-core): respect child index position when calculating key (削除ここまで)
(追記) fix(compiler-core): v-if key increment also based on other type siblings (追記ここまで)
Apr 22, 2022
Contributor
Author
yuwu9145
commented
Apr 22, 2022
I will add tests soon
@yuwu9145
yuwu9145
force-pushed
the
fix-5762
branch
2 times, most recently
from
April 22, 2022 12:10
dad9798 to
cc93966
Compare
@yuwu9145
yuwu9145
changed the title
(削除) fix(compiler-core): v-if key increment also based on other type siblings (削除ここまで)
(追記) fix(runtime-core): avoid number type transition child key duplicating with index key (追記ここまで)
Apr 22, 2022
@yuwu9145
yuwu9145
force-pushed
the
fix-5762
branch
2 times, most recently
from
April 26, 2022 05:36
ea78b49 to
0050a37
Compare
@yuwu9145
yuwu9145
force-pushed
the
fix-5762
branch
from
March 19, 2023 22:28
0050a37 to
e620241
Compare
Size ReportBundles
Usages
|
@vue/compiler-core
pnpm add https://pkg.pr.new/@vue/compiler-core@5779
@vue/compiler-dom
pnpm add https://pkg.pr.new/@vue/compiler-dom@5779
@vue/compiler-sfc
pnpm add https://pkg.pr.new/@vue/compiler-sfc@5779
@vue/compiler-ssr
pnpm add https://pkg.pr.new/@vue/compiler-ssr@5779
@vue/reactivity
pnpm add https://pkg.pr.new/@vue/reactivity@5779
@vue/runtime-core
pnpm add https://pkg.pr.new/@vue/runtime-core@5779
@vue/runtime-dom
pnpm add https://pkg.pr.new/@vue/runtime-dom@5779
@vue/server-renderer
pnpm add https://pkg.pr.new/@vue/server-renderer@5779
@vue/shared
pnpm add https://pkg.pr.new/@vue/shared@5779
vue
pnpm add https://pkg.pr.new/vue@5779
@vue/compat
pnpm add https://pkg.pr.new/@vue/compat@5779
commit: 0fbfb31
@edison1105
edison1105
added
ready to merge
The PR is ready to be merged.
🔩 p2-edge-case
labels
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
close #5761