Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(compat): fix compat handler of draggable #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yangxiuxiu1115 wants to merge 8 commits into vuejs:main
base: main
Choose a base branch
Loading
from yangxiuxiu1115:fix/compat-attr
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/runtime-dom/src/modules/attrs.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,11 @@ export function compatCoerceAttr(
): boolean {
if (isEnumeratedAttr(key)) {
const v2CoercedValue =
value === null
? 'false'
: typeof value !== 'boolean' && value !== undefined
? 'true'
: null
value === undefined
? null
: value === null || value === false || value === 'false'
? 'false'
: 'true'
if (
v2CoercedValue &&
compatUtils.softAssertCompatEnabled(
Expand Down
21 changes: 21 additions & 0 deletions packages/vue-compat/__tests__/misc.spec.ts
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,24 @@ test('ATTR_ENUMERATED_COERCION', () => {
)('contenteditable', 'foo', 'true'),
).toHaveBeenWarned()
})

test('ATTR_ENUMERATED_COERCION, coercing "false"', () => {
const vm = new Vue({
template: `<div><div draggable="false" :spellcheck="false">hello</div></div>`,
}).$mount()
expect(vm.$el.innerHTML).toBe(
`<div draggable="false" spellcheck="false">hello</div>`,
)
expect(
(
deprecationData[DeprecationTypes.ATTR_ENUMERATED_COERCION]
.message as Function
)('draggable', 'false', 'false'),
).toHaveBeenWarned()
expect(
(
deprecationData[DeprecationTypes.ATTR_ENUMERATED_COERCION]
.message as Function
)('spellcheck', 'false', 'false'),
).toHaveBeenWarned()
})
Loading

AltStyle によって変換されたページ (->オリジナル) /