fix(transition): cancel the delayed execution of the transition enter hook #12133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

yangxiuxiu1115 wants to merge 3 commits into vuejs:main

from yangxiuxiu1115:fix/transition-enter

Open

fix(transition): cancel the delayed execution of the transition enter hook #12133

yangxiuxiu1115 wants to merge 3 commits into vuejs:main from yangxiuxiu1115:fix/transition-enter

Conversation

@yangxiuxiu1115

Copy link

Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Oct 9, 2024

fix #12091


 fix(transition): cancel the delayed execution of the transition enter...

0881c2e

... hook

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft

October 9, 2024 08:21

@pkg-pr-new

Copy link

pkg-pr-new bot commented Oct 9, 2024 •

edited

Loading

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12133

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12133

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12133

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12133

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12133

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12133

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12133

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12133

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12133

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12133

vue

pnpm add https://pkg.pr.new/vue@12133

commit: a92d1bb

@github-actions

Copy link

github-actions bot commented Oct 9, 2024 •

edited

Loading

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB (-6 B)	38.1 kB (-6 B)	34.3 kB (+98 B)
vue.global.prod.js	160 kB (-6 B)	58 kB (-9 B)	51.5 kB (-7 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	49.1 kB (-3 B)	18.9 kB (-4 B)	17.3 kB (-6 B)
createApp	55.7 kB (-3 B)	21.4 kB (-2 B)	19.5 kB (-53 B)
createSSRApp	59.7 kB (-6 B)	23.1 kB (-7 B)	21 kB (+8 B)
defineCustomElement	60.4 kB (-3 B)	23 kB (-2 B)	20.9 kB (+45 B)
overall	69.4 kB (-3 B)	26.5 kB (-2 B)	24.1 kB (+43 B)


 chore: update

e50557a

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review

October 9, 2024 09:20

@edison1105

Copy link

Member

edison1105 commented Oct 10, 2024

/ecosystem-ci run

@vue-bot

Copy link

Contributor

vue-bot commented Oct 10, 2024

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
language-tools	❌ failure	❌ failure
nuxt	✅ success	✅ success
pinia	✅ success	✅ success
primevue	✅ success	✅ success
quasar	✅ success	✅ success
radix-vue	✅ success	✅ success
router	✅ success	✅ success
test-utils	✅ success	✅ success
vant	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
vitepress	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-macros	✅ success	✅ success
vuetify	✅ success	✅ success
vueuse	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

@edison1105

Copy link

Member

edison1105 commented Oct 10, 2024 •

edited

Loading

I'm not sure if this change will cause any edge case issues.
if the changes in this PR are correct, then maybe this part also needs to be modified to remain consistent.

@edison1105 edison1105 added scope: transition ready for review labels

Oct 10, 2024


 chore: update

a92d1bb

Labels

ready for review scope: transition

3 participants

@yangxiuxiu1115 @edison1105 @vue-bot

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(transition): cancel the delayed execution of the transition enter hook #12133

Are you sure you want to change the base?

fix(transition): cancel the delayed execution of the transition enter hook #12133

Uh oh!

Conversation

@yangxiuxiu1115 yangxiuxiu1115 commented Oct 9, 2024

Uh oh!

pkg-pr-new bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2024 •

edited

Loading

Uh oh!

Size Report

Bundles

Usages

Uh oh!

edison1105 commented Oct 10, 2024

Uh oh!

vue-bot commented Oct 10, 2024

Uh oh!

edison1105 commented Oct 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix(transition): cancel the delayed execution of the transition enter hook #12133

Are you sure you want to change the base?

fix(transition): cancel the delayed execution of the transition enter hook #12133

Uh oh!

Conversation

@yangxiuxiu1115 yangxiuxiu1115 commented Oct 9, 2024

Uh oh!

pkg-pr-new bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Report

Bundles

Usages

Uh oh!

edison1105 commented Oct 10, 2024

Uh oh!

vue-bot commented Oct 10, 2024

Uh oh!

edison1105 commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pkg-pr-new bot commented Oct 9, 2024 •

edited

Loading

github-actions bot commented Oct 9, 2024 •

edited

Loading

edison1105 commented Oct 10, 2024 •

edited

Loading