-
Notifications
You must be signed in to change notification settings - Fork 101
Do not inheritAttrs on ModalContainer #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
develth
commented
Oct 2, 2024
great - would fix annoying error
@genu
genu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this PR lands soon to make the Warnings go away! I appreciate the effort.
@genu
genu
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should contain only this change alone. The version updates are handled upon release/publish.
An explanation of the issue would helpful. Why does this need to be false?
@genu
genu
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't have to bump these in this PR. ( See other comment)
@genu
genu
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we're bumping version, we also get a new lock, which we don't want.
@genu
genu
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comments.
Actually I have no idea if it is necessary to have attributes on the ModalContainer. If not this PR should solve: #453