-
-
Notifications
You must be signed in to change notification settings - Fork 3
Comments
fix: ensure initial matching when -input= option is provided#47
Merged
lambdalisue merged 1 commit intomain from Oct 18, 2025
Merged
fix: ensure initial matching when -input= option is provided #47lambdalisue merged 1 commit intomain from
lambdalisue merged 1 commit intomain from
Conversation
The previous implementation set initialQuery to #previousQuery, which prevented the first matching from executing when an initial query was provided via the -input= option. This fix ensures the first matching always runs by keeping #previousQuery undefined on initialization.
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.84%. Comparing base (abfe3b7) to head (cd1fd63).
Additional details and impacted files
@@ Coverage Diff @@ ## main #47 +/- ## ======================================= Coverage 83.84% 83.84% ======================================= Files 32 32 Lines 2024 2024 Branches 214 214 ======================================= Hits 1697 1697 Misses 324 324 Partials 3 3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-input=optioninitialQuerywas being set to#previousQuery, which prevented the matching logic from detecting a query changeChanges
#previousQuerytoundefinedon initialization instead ofinitialQuery-input=option to work correctlyTest plan
-input=option triggers initial matching-input=still works as expectedNotes
Recreated from main branch to ensure clean CI runs.