-
-
Notifications
You must be signed in to change notification settings - Fork 3
Comments
perf: optimize picker performance with event queue and preview debouncing#38
Merged
lambdalisue merged 5 commits intomain from Jul 6, 2025
Merged
perf: optimize picker performance with event queue and preview debouncing #38lambdalisue merged 5 commits intomain from
lambdalisue merged 5 commits intomain from
Conversation
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 82.14%. Comparing base (
e435174) to head (3bb15e4).
Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #38 +/- ## ========================================== + Coverage 81.77% 82.14% +0.37% ========================================== Files 26 27 +1 Lines 1761 1798 +37 Branches 176 185 +9 ========================================== + Hits 1440 1477 +37 Misses 318 318 Partials 3 3
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@lambdalisue
lambdalisue
force-pushed
the
performance-imp
branch
from
July 6, 2025 12:46
0f90033 to
8c92a7d
Compare
@lambdalisue
lambdalisue
changed the title
(削除) feat: implement performance optimizations for fall picker (削除ここまで)
(追記) perf: optimize picker performance with event queue and preview debouncing (追記ここまで)
Jul 6, 2025
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Cache byte length calculations for prefix and suffix strings in InputComponent to avoid repeated getByteLength() calls during rendering. This improves performance when the same prefix/suffix values are used repeatedly. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace forEach with for loop for better performance and add early return when event queue is empty. Also add comprehensive tests for event handling including edge cases for large event counts and events dispatched during consumption. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Modify picker event handlers to restart only the affected processor instead of restarting from the matcher. When sorter changes, restart sort processor with matcher output. When renderer changes, restart render processor with sorter output. This avoids redundant matching operations. Also implement copy-on-write for sort processor to prevent modifying the input array, ensuring pipeline integrity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
@lambdalisue
lambdalisue
force-pushed
the
performance-imp
branch
from
July 6, 2025 12:53
dd0de9f to
6704a15
Compare
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
@lambdalisue
lambdalisue
force-pushed
the
performance-imp
branch
from
July 6, 2025 12:53
6704a15 to
3bb15e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Changes
Performance Impact
These changes significantly improve the responsiveness of the fall picker, especially when:
🤖 Generated with Claude Code