-
Notifications
You must be signed in to change notification settings - Fork 74
@vercel/flags-core: add flag/variant IDs for evaluation tracking#336
Draft
dferber90 wants to merge 1 commit into
Draft
@vercel/flags-core: add flag/variant IDs for evaluation tracking #336dferber90 wants to merge 1 commit into
dferber90 wants to merge 1 commit into
Conversation
... and evaluation tracking Add `id` and `variantIds` fields to `Packed.FlagDefinition` so evaluations can be reported with stable IDs. The evaluate function now resolves `variantId` directly and includes it on `EvaluationResult`. A new `FLAG_EVALUATION` event type is sent to `/v1/ingest` via `UsageTracker.trackEvaluation()`, and the OpenFeature provider now returns `variant` on `ResolutionDetails`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
miraan
miraan
reviewed
Mar 17, 2026
variantId: options.variantId,
reason: options.reason,
deploymentId: process.env.VERCEL_DEPLOYMENT_ID,
region: process.env.VERCEL_REGION,
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we send environment too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
idandvariantIdsfields toPacked.FlagDefinitionso evaluations can reference flags and variants by stable IDsvariantIddirectly and includes it onEvaluationResultFLAG_EVALUATIONevent type sent to/v1/ingestviaUsageTracker.trackEvaluation()for dashboard displayvariantonResolutionDetailsper the specTest plan
variantIdisundefinedwhenvariantIdsnot present in definitionFLAG_EVALUATIONevents appear in/v1/ingestwith correctflagId/variantId/reason🤖 Generated with Claude Code