-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix: Move useOptimistic to provider level for consistent cart state#1469
Open
francomay3 wants to merge 1 commit intovercel:main from
Open
Fix: Move useOptimistic to provider level for consistent cart state #1469francomay3 wants to merge 1 commit intovercel:main from
francomay3 wants to merge 1 commit intovercel:main from
Conversation
- Move useOptimistic from useCart hook to CartProvider - Create single shared optimistic cart instance - Eliminate lag between cart operations and UI updates - Ensure all components see consistent cart state
Contributor
Someone is attempting to deploy a commit to the Vercel Solutions Team on Vercel.
A member of the Team first needs to authorize it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fix: Move useOptimistic to provider level for consistent cart state
Background:
Discovered a bug where there was noticeable lag between adding products to cart and seeing the cart update. Initially confusing because
useOptimisticwas being used throughout the codebase, but the issue was that eachuseCart()hook call was creating its own optimistic cart instance.Problem:
Cart updates had lag because
useOptimisticwas being created in eachuseCart()hook call, resulting in multiple optimistic cart instances. Components using the cart outside of the hook were seeing the actual cart (with server delay) while hook consumers saw the optimistic cart, causing inconsistent UI updates.Solution:
Moved
useOptimisticfrom theuseCarthook to theCartProvidercomponent, creating a single shared optimistic cart instance that all components can access through the context.Result:
All cart operations now update instantly across the entire application, eliminating the lag between adding items and seeing them in the cart UI.
Files changed:
components/cart/cart-context.tsx