Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

cmake: add explicit build options to QNX presets #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VJanKraemer merged 1 commit into main from use_qnx_preset
Jan 28, 2026
Merged

Conversation

@VJanKraemer
Copy link
Contributor

@VJanKraemer VJanKraemer commented Jan 22, 2026
edited
Loading

Description

QNX needs specific CMAKE Options since not all options work with the SDK and toolchains for QNX

Developer checklist (address before review)

  • (削除) Changelog.md updated (削除ここまで) No user visible change
  • (削除) Prepared update for depending repositories (削除ここまで)
  • (削除) Documentation updated (public API changes only) (削除ここまで)
  • (削除) API docstrings updated (public API changes only) (削除ここまで)
  • Rebase → commit history clean
  • Squash and merge → proper PR title

Copy link
Member

@VDanielEdwards VDanielEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 I saw that the preset defined the environment variable SILKIT_CMAKE_PRESET_BUILD_PLATFORM. However this does not seem to be used anywhere?

VJanKraemer reacted with thumbs up emoji
Signed-off-by: Jan Kraemer <jan.kraemer@vector.com>
@VJanKraemer VJanKraemer merged commit 1dfb694 into main Jan 28, 2026
15 checks passed
@VJanKraemer VJanKraemer deleted the use_qnx_preset branch January 28, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MariusBgm MariusBgm MariusBgm left review comments

@VDanielEdwards VDanielEdwards VDanielEdwards approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /