-
Notifications
You must be signed in to change notification settings - Fork 44
Set Demo and Utility RPATHs to match system defaults
#291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+16
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
Signed-off-by: Marius Behrens <marius.behrens@synopsys.com>
@snps-behrens
snps-behrens
force-pushed
the
install_rpath
branch
from
January 21, 2026 14:06
a67cf8a to
2fe1585
Compare
@snps-behrens
snps-behrens
changed the title
(削除) Set Demo and Utility
(追記) Set Demo and Utility Jan 22, 2026
RPATHs to match sytem defaults (削除ここまで)RPATHs to match system defaults (追記ここまで)
@VJanKraemer
VJanKraemer
requested review from
VJanKraemer
and removed request for
MariusBgm
January 22, 2026 08:27
VJanKraemer
VJanKraemer
approved these changes
Jan 22, 2026
Contributor
@VJanKraemer
VJanKraemer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and congratulations on your first PR 🥳
Please squash the commits before merging and I think the PR title would also be a good, descriptive commit msg header. Any additional info should be in the msg body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
When a SIL Kit installation is built, the system default is used to name the lib-directory in the install hierarchy. On certain Linux distributions (Alma Linux, for instance) this default lib-directory is
lib64instead oflib. This results in the SIL Kit Demos and Utilities not being able to findlibSilKit.sobecause their RPATH is hard-coded to uselib.This PR proposes setting these
RPATHs to match the naming scheme used when creating the SIL Kit installation (as defined by theGNUInstallDirsCMake module).Developer checklist (address before review)