-
Notifications
You must be signed in to change notification settings - Fork 44
SILKIT-1896: Fix start of registry for Windows system service #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SILKIT-1896: Fix start of registry for Windows system service #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the Windows service start path was using the wrong URI variable (listenUri from command line instead of configuredListenUri extracted from the sanitized configuration). The fix refactors the code to use a single lambda function for both Windows service and non-service execution paths.
Key Changes:
- Introduces a lambda
callStartRegistrythat captures the correctconfiguredListenUriand other parameters - Updates the Windows service path to use this lambda (fixing the original bug)
- Refactors the non-Windows service path to use the same lambda for consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@VDanielEdwards
VDanielEdwards
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you! 👍
Signed-off-by: Becker, Lukas <Lukas.Becker@vector.com>
b895b2a to
ef95846
Compare
Subject
Description
Developer checklist (address before review)