-
Notifications
You must be signed in to change notification settings - Fork 14
tests(config-variations): Git schemes in repo URLs #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
2 times, most recently
from
October 22, 2023 17:37
30b561b to
8075ac0
Compare
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
from
February 23, 2024 02:22
8075ac0 to
29167fd
Compare
@tony
tony
force-pushed
the
master
branch
4 times, most recently
from
November 25, 2024 23:02
206715e to
0f25cdd
Compare
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
2 times, most recently
from
April 20, 2025 22:55
f0359d6 to
7c14a3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #426 +/- ## ========================================== - Coverage 78.98% 78.98% -0.01% ========================================== Files 8 9 +1 Lines 414 452 +38 Branches 85 94 +9 ========================================== + Hits 327 357 +30 - Misses 52 57 +5 - Partials 35 38 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
2 times, most recently
from
April 21, 2025 15:11
fdfabb9 to
d270f39
Compare
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
from
April 26, 2025 09:14
d270f39 to
530c10e
Compare
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Jun 22, 2025
Related to vcs-python/vcspull#49, vcs-python/vcspull#426 **In main repo URLs:** Main repo URLs require `libvcs.url.git.GitURL` support: Scheme: `user@domain.tld:org/repo.git` Example: `git@github.com:tmux-python/tmuxp.git` Note: The workaround is to prepend `git+ssh://git@github.com:tmux-python/tmuxp.git`
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
from
June 22, 2025 14:00
530c10e to
b99735a
Compare
why: - Previously, enabling SSH-style URL detection mutated libvcs’s DEFAULT_RULES on import and lost the rule’s original metadata. - Users couldn’t cleanly disable the patch or restore upstream defaults if libvcs changed. - Implicit module-import side-effects are harder to reason about. what: - Introduce private `_orig_rule_meta` to snapshot rule’s original metadata. - Store original metadata on first enable and apply `(True, 100)`. - Restore saved metadata (or safe defaults) on disable, clearing snapshot. - Remove auto-patch on import; require explicit call. - Add `ssh_style_url_detection` context manager. - Call `enable_ssh_style_url_detection()` in `update_repo()` to maintain behavior. - Add pytest tests for enable/disable roundtrip and context manager.
@tony
tony
force-pushed
the
git-remote-url-scheme-pt2
branch
from
June 22, 2025 14:08
b99735a to
1f39d80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #49
In main repo URLs:
Main repo URLs require
libvcs.url.git.GitURLsupport:Scheme:
user@domain.tld:org/repo.gitExample:
git@github.com:tmux-python/tmuxp.gitFor remote URLs, see #419
Note: The workaround is to prepend
git+ssh://git@github.com:tmux-python/tmuxp.git