This repository was archived by the owner on Nov 20, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 671
feat: Import a separate file for ICE servers#34
Open
tomershvueli wants to merge 1 commit intovasanthv:master from
Open
feat: Import a separate file for ICE servers #34tomershvueli wants to merge 1 commit intovasanthv:master from
tomershvueli wants to merge 1 commit intovasanthv:master from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR slightly speaks towards issue #30. By extrapolating the ICE servers array definition to a separate file, an automated build process can override these values easier by simply overwriting this file, instead of having to edit the original script.js file.
Since the new JS file is being imported above the script.js in the index.html page, all current Docker builds, etc should continue to work fine without a hitch.