-
-
Notifications
You must be signed in to change notification settings - Fork 55
Shut down the driver's connection pool safely #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...call EventLoopFuture.wait() internally.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #220 +/- ## ======================================= Coverage 63.77% 63.77% ======================================= Files 8 8 Lines 334 334 ======================================= Hits 213 213 Misses 121 121
|
0xTim
0xTim
approved these changes
May 24, 2024
The TSan failure in the 5.8 CI is a false positive that was fixed in 5.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
These changes are now available in 2.9.2
Specifically, don't use the soft-deprecated AsyncKit API that calls
EventLoopFuture.wait()internally; use the one that at least does it with Dispatch (best we can do without changing Fluent's driver interface).