Update PostgresError's DatabaseError conformance for new PostgresNIO behavior #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gwynne merged 1 commit into main from fix-database-error-test

May 7, 2023

Merged

Update PostgresError's DatabaseError conformance for new PostgresNIO behavior #208

gwynne merged 1 commit into main from fix-database-error-test

May 7, 2023

Conversation

gwynne

Copy link

Member

@gwynne gwynne commented May 7, 2023

This makes DatabaseError.isSyntaxError and .isConstraintFailure work again.

@gwynne


 Update PostgresError's DatabaseError conformance for new PostgresNIO ...

ec340a6

...behavior. Fixes broken tests.

@gwynne gwynne added bug semver-patch labels

May 7, 2023

@gwynne gwynne requested a review from 0xTim

May 7, 2023 04:21

@codecov-commenter

Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #208 (ec340a6) into main (c7cd020) will decrease coverage by 0.75%.
The diff coverage is 23.80%.

Additional details and impacted files

@@ Coverage Diff @@
## main #208 +/- ##
==========================================
- Coverage 77.29% 76.55% -0.75% 
==========================================
 Files 7 7 
 Lines 414 354 -60 
==========================================
- Hits 320 271 -49 
+ Misses 94 83 -11