-
-
Notifications
You must be signed in to change notification settings - Fork 55
Updated to use new PostgresKit/PostgresNIO APIs #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...d FluentPostgresDatabase to use SQLDatabase for (almost) everything instead of duplicating PostgresKit's work. Ditch uses of old APIs.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## main #207 +/- ## =========================================== - Coverage 76.55% 62.39% -14.17% =========================================== Files 7 8 +1 Lines 354 343 -11 =========================================== - Hits 271 214 -57 - Misses 83 129 +46
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query around the needing to change the migrations, if that's all good then we're good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference for anyone else reviewing - this is now handled in PostgresKit
VaporBot
commented
May 9, 2023
These changes are now available in 2.7.0
Uh oh!
There was an error while loading. Please reload this page.
PostgresKit 2.11.0 heavily revamped PostgresKit to take full (or near to it) advantage of the modern PostgresNIO APIs. These changes do the same for FluentPostgresDriver, including adopting the revisions made to PostgresKit's API. This incidentally results in a significant improvement in the layering of the three packages, with FluentPostgresDriver now relying almost entirely on PostgresKit alone rather than needing to separately know details of PostgresNIO (with one or two exceptions). The end result is much cleaner code and moderate performance improvements.
Swift 5.7 or later is now required.
Users who previously specified custom
PostgresDataEncoder
and/orPostgresDataDecoder
instances in their database configurations will begin receiving deprecation warnings; the replacements are PostgresNIO'sPostgresEncodingContext
andPostgresDecodingContext
: