-
-
Notifications
You must be signed in to change notification settings - Fork 55
Remove invalid model definition from test #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...n with anyway. (Model used @id(key:) with a non-UUID value)
...ightly test, enable TSan)
@gwynne
gwynne
force-pushed
the
fix-bad-test
branch
from
March 3, 2023 13:12
9199c04 to
2b2a226
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@ ## main #203 +/- ## ========================================== - Coverage 78.74% 77.29% -1.45% ========================================== Files 7 7 Lines 414 414 ========================================== - Hits 326 320 -6 - Misses 88 94 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
0xTim
0xTim
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The test doesn't use the definition in any event.
Also some nice CI cleanup.