-
Notifications
You must be signed in to change notification settings - Fork 29
Replace ICU4J UCharacter methods with standard Java Character class - #118
Merged
sideshowbarker merged 1 commit intoMay 12, 2026
Merged
Conversation
ICU4J 75.1 removed the char-taking overloads of UCharacter methods: - isHighSurrogate(char) — removed (only isHighSurrogate(int) remains) - isLowSurrogate(char) — removed (only isLowSurrogate(int) remains) - getCodePoint(char, char) — removed (only getCodePoint(int, int) remains) When code compiled against an older ICU4J (which had those methods) runs with ICU4J 75.1, it throws NoSuchMethodError — because the bytecode contains direct references to the removed method signatures. Note: Code compiled against ICU4J 75.1 happens to work because Java’s implicit widening conversion (char → int) binds to the int versions at compile time. But that doesn’t help users of pre-compiled artifacts. This change replaces all uses of those ICU4J methods with equivalent methods from Java’s standard Character class (available since Java 5): - UCharacter.isHighSurrogate(c) → Character.isHighSurrogate(c) - UCharacter.isLowSurrogate(c) → Character.isLowSurrogate(c) - UCharacter.getCodePoint(c1, c2) → Character.toCodePoint(c1, c2)
sideshowbarker
force-pushed
the
ICU4J-UCharacter-replace-with-standard-Java-Character
branch
from
May 12, 2026 08:10
919b5fb to
6699f5c
Compare
hsivonen
hsivonen
approved these changes
May 12, 2026
@hsivonen
hsivonen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
sideshowbarker
deleted the
ICU4J-UCharacter-replace-with-standard-Java-Character
branch
May 12, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
ICU4J 75.1 removed the char-taking overloads of UCharacter methods:
When code compiled against an older ICU4J (which had those methods) runs with ICU4J 75.1, it throws NoSuchMethodError — because the bytecode contains direct references to the removed method signatures.
Note: Code compiled against ICU4J 75.1 happens to work because Java’s implicit widening conversion (char → int) binds to the int versions at compile time. But that doesn’t help users of pre-compiled artifacts.
This change replaces all uses of those ICU4J methods with equivalent methods from Java’s standard Character class (available since Java 5):