-
Notifications
You must be signed in to change notification settings - Fork 29
Implement <select> parser "relaxation" — for "customizable" <select> - #113
Merged
Merged
Implement <select> parser "relaxation" — for "customizable" <select> #113sideshowbarker merged 1 commit into
sideshowbarker merged 1 commit into
Conversation
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
2 times, most recently
from
December 30, 2025 08:00
cdf2934 to
a1d8a3d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
hsivonen
hsivonen
requested changes
Jan 23, 2026
@hsivonen
hsivonen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the delay.
As discussed on Matrix, I think the way this patch makes the cloning work on what the parser saw is incorrect and the spec instead requires the cloning to work on what's in the live DOM, which may be different if the option element opens, the network stalls, setTimeout modifies the DOM, and network resumes.
Further remarks in an inline comment.
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
5 times, most recently
from
February 2, 2026 05:35
f7b4c0f to
87fe37a
Compare
hsivonen
hsivonen
reviewed
Feb 4, 2026
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
from
February 20, 2026 12:55
0466829 to
b3bbf98
Compare
hsivonen
hsivonen
requested changes
Mar 12, 2026
@hsivonen
hsivonen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry that I've been in a very bad time management loop.
This looks very good, but there are some minor issues.
Thank you!
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
from
March 12, 2026 13:27
b3bbf98 to
66f24d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
from
March 12, 2026 14:12
66f24d6 to
8ad0683
Compare
sideshowbarker
commented
Mar 12, 2026
Member
Author
@hsivonen OK, all comments now resolved, I think. Ready for you to review again.
hsivonen
hsivonen
approved these changes
Mar 13, 2026
@hsivonen
hsivonen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this. Thank you and sorry about delay.
hsivonen
hsivonen
approved these changes
Mar 16, 2026
@hsivonen
hsivonen
left a comment
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Relax "select"-element parsing to allow more child elements, and handle the "selectedcontent" element for cloning "option"-element content.
sideshowbarker
force-pushed
the
sideshowbarker/relaxed-select-parsing
branch
from
March 17, 2026 06:11
39f24fc to
f275246
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Relax
selectparsing to allow more child elements, and handle theselectedcontentelement for cloningoptioncontent.