-
Notifications
You must be signed in to change notification settings - Fork 1
Optimize Viewer: Single Diff Calculation with Dual Minimap Display #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for virtual-react-json-diff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @utkuakyuz, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant performance and usability enhancements to the diff viewer, primarily by optimizing the minimap rendering process. It transitions from on-the-fly rendering to a precomputed, offscreen canvas approach, which drastically improves responsiveness and reduces resource consumption. The changes also enable a dual minimap display, providing a more comprehensive visual overview of the diff while maintaining a smooth and interactive experience.
Highlights
- Performance Optimization: The diff viewer now pre-renders the entire diff to an offscreen canvas, significantly reducing CPU usage and enabling smoother interactions, especially for large files.
- Dual Minimap Display: The precomputed diff is utilized to display two identical minimaps on both sides of the viewer, enhancing navigation and visual context without redundant calculations.
- Reduced Redraws: Unnecessary redraws during scrolling, search highlighting, and diff updates have been minimized, contributing to a more fluid user experience.
- Enhanced Interactivity: Both minimaps maintain full interactivity (click/drag) with visual feedback (opacity changes) while keeping the overlay lightweight.
- New Development Scripts: Added
watchanddev:watchscripts topackage.jsonfor improved developer workflow, allowing simultaneous watching of rollup builds and the demo application.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant performance optimization for the diff viewer by pre-rendering the diff to an offscreen canvas and using it to display dual minimaps. This is a great improvement that should reduce CPU usage and improve user experience. My review includes feedback on a UI bug involving a duplicated button, a suggestion to reduce code duplication, a fix for a potential bug in a React hook's dependency array, and some recommendations for improving code quality by aligning with React best practices and cleaning up CSS.
Uh oh!
There was an error while loading. Please reload this page.
This PR improves the performance and usability of the diff viewer by:
This change significantly reduces CPU usage and ensures smoother scrolling and interactions, especially for large files.
New viewer will look like this. Performance increase made scrollbox move smoother.
imageLeft minimap can be hidden by simply changing the showSingleMinimap (default true) to false