-
Notifications
You must be signed in to change notification settings - Fork 1
New demo app created replacing storybook #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for virtual-react-json-diff ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @utkuakyuz, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the project's demonstration environment by replacing the existing Storybook setup with a new, custom-built demo application. The primary goal is to provide a more efficient and tailored showcase for the single component within the package. This change enhances the user experience by offering a dedicated interface for configuring and testing the component, improving JSON input validation, and streamlining the overall interaction with the demo.
Highlights
- Storybook Replacement: Replaced Storybook with a custom-built demo application, as Storybook was deemed inefficient for a package containing only one component.
- Enhanced Configuration Options: Introduced a new sidebar within the demo app that provides comprehensive configuration options for the diff viewer, allowing dynamic adjustment of settings.
- Improved JSON Handling: Implemented corrected JSON validation that pinpoints the exact location of errors and integrated ACE editors for a superior JSON editing experience, including seamless copy-paste functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully replaces Storybook with a dedicated demo application. This is a good move for a single-component library, as it provides a more tailored and efficient demonstration environment. The new demo app is well-structured, offering a good user experience with live configuration updates and improved JSON validation. My review includes a few suggestions to enhance type safety, improve security practices in links, and follow CSS best practices to increase maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Storybook was not efficient for such kind of package including only one component. So instead of it a new demo app is introduced.
- Sidebar including all configuration options.
- Corrected JSON validation, showing where validation error occurs.
- Better user experience thanks to ACE editors.
- Copy Paste JSON properly.
imageResolves #14