Лопатин Николай#93

Open

LopatinNikolai wants to merge 20 commits into

urfu-2018:master from

LopatinNikolai:master

Open

Лопатин Николай #93
LopatinNikolai wants to merge 20 commits into
urfu-2018:master from
LopatinNikolai:master

Conversation

@LopatinNikolai

@LopatinNikolai LopatinNikolai commented Oct 25, 2018

Copy link

Copy Markdown

No description provided.

@LopatinNikolai


 javascript-task-2

706c380

@honest-hrundel honest-hrundel changed the title ~~(削除) javascript-task-2 (削除ここまで)~~ (追記) Лопатин Николай (追記ここまで)

Oct 25, 2018

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 16 из 26

@LopatinNikolai


 javascript-task-2.1

9ec7afc

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Не пройден линтинг или базовые тесты

@LopatinNikolai


 javascript-task-2.2

65d7171

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 16 из 26

@LopatinNikolai


 javascript-task-2.3

4ee4431

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 16 из 26

@LopatinNikolai


 javascript-task-2.4

93663b2

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 17 из 26

@LopatinNikolai


 javascript-task-2.5

c55cf05

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 17 из 26

@LopatinNikolai


 javascript-task-2.5

4869afc

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 18 из 26

@LopatinNikolai


 javascript-task-2.6

70c43ee

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 18 из 26

@LopatinNikolai


 javascript-task-2.7

5f55706

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 18 из 26

@LopatinNikolai


 javascript-task-2.8

9477dd7

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.9

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.91

3b0a94c

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 check

6257f48

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 19 из 23

@LopatinNikolai


 javascript-task-2.91

0822a48

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.92

a47065b

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.93

70efbba

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.94

4aeab3a

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.95

a2e08ec

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.96

a0432fe

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍅 Пройдено тестов 22 из 26

@LopatinNikolai


 javascript-task-2.97

3ef7da6

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

🍏 Пройдено тестов 26 из 26

@honest-hrundel honest-hrundel assigned plotnikovn

Oct 25, 2018

@honest-hrundel

honest-hrundel commented Oct 25, 2018

Copy link

Copy Markdown

@plotnikovn обрати внимание: решено доп. задание

plotnikovn

plotnikovn requested changes

Oct 25, 2018

View reviewed changes

phone-book.js

function check(phone, name) {

if (typeof phone !== 'string' || typeof name !== 'string' || name.length <= 0 ||

phone <= 0) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

– длина строки не может быть отрицательной
– phone <= 0 не лучшая идея сравнивать на строку с числом

phone-book.js

return false;

}

return /^\d{10}$/.test(phone);

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

длину телефона можно не проверять, т.к. в регулярном выражении ты задаешь фиксированное количество символов

phone-book.js

return /^\d{10}$/.test(phone);

}

function check2(email) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай осмысленные названия функциям

phone-book.js

return false;

}

if (email === undefined) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут лучше поменять местами, и тогда проверка станет проще

if (email === undefined) {
 return true;
}
return typeof email === 'string' && email.length;

phone-book.js

}

function generalCheck(phone, name, email) {

if (check(phone, name) === false || check2(email) === false) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно сразу сделать return

return check(...) || check2(...);

phone-book.js

* @returns {Boolean}

function add(phone, name, email) {

if (generalCheck(phone, name, email) === false) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!generalCheck(...)) {
...
}

phone-book.js

if (generalCheck(phone, name, email) === false) {

return false;

}

if (checkPhone(phone) === true) {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

аналогично

phone-book.js

if (generalCheck(phone, name, email) === false) {

return false;

}

phoneBook.forEach(element => {

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

здесь лучше подойдет .some
https://developer.mozilla.org/ru/docs/Web/JavaScript/Reference/Global_Objects/Array/some

phone-book.js

if (element.phone.includes(query) === true ||

element.name.includes(query) === true ||

(element.email ? element.email.includes(query) : false)) {

string = element.name + ', +7 (' + element.phone.slice(0, 3) + ') ' +

@plotnikovn plotnikovn Oct 25, 2018

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лучше сделать отдельную функцию для форматирования записи

Labels

None yet

3 participants

@LopatinNikolai @honest-hrundel @plotnikovn

Uh oh!

Conversation

@LopatinNikolai LopatinNikolai commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

honest-hrundel commented Oct 25, 2018

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

@plotnikovn plotnikovn Oct 25, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants