Search code, repositories, users, issues, pull requests...

ninjagrizzly reviewed

lego.js

var changedCollection = collection.map(function (el) {

return Object.assign({}, el);

});

functions.sort(function (first, second) {

@ninjagrizzly ninjagrizzly Nov 4, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для функции сортировки можно параметры называть a и b

ninjagrizzly reviewed

lego.js

var fieldsToChoose = [].slice.call(arguments);

return function select(collection) {

return collection.map(function (el) {

@ninjagrizzly ninjagrizzly Nov 4, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el не несет никакой семантики, лучше подойдет название вроде person

ninjagrizzly reviewed

lego.js

return function select(collection) {

return collection.map(function (el) {

return fieldsToChoose.reduce(function (newCollection, property) {

@ninjagrizzly ninjagrizzly Nov 4, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Первый аргумент назвал newCollection, но ведь это не коллеция, а объект с информацией о человеке

ninjagrizzly reviewed

lego.js

console.info(property, values);

return;

return function filterIn(collection) {

@ninjagrizzly ninjagrizzly Nov 4, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Снова el никак не отражает того, что лежит внутри (в общем везде el нужно поменять)

ninjagrizzly reviewed

lego.js

return;

return function sortBy(collection) {

var changedCollection = collection.sort(function (first, second) {

@ninjagrizzly ninjagrizzly Nov 4, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Зачем еще одну переменную создавать? Можно просто collection.sort()

ninjagrizzly reviewed