Search code, repositories, users, issues, pull requests...

@Zeace Zeace commented Oct 30, 2016

Copy link

Copy Markdown

No description provided.


 первый заход

bafc611

honest-hrundel commented Oct 30, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Oct 30, 2016

Copy link

Copy Markdown

@Lakate обрати внимание решено доп. задание

@honest-hrundel honest-hrundel assigned Lakate

Oct 30, 2016

Lakate

Lakate reviewed

Nov 1, 2016

View reviewed changes

lego.js

function sortByPriority(a, b) {

var priority = ['filterIn', 'and', 'or', 'sortBy', 'select', 'limit', 'format'];

return priority.indexOf(b.name) < priority.indexOf(a.name);

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lego.js Outdated

var operators = [].slice.call(arguments, 1);

operators.sort(sortByPriority);

for (var i = 0; i < operators.length; i++) {

copy = operators[i](copy);

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай дадим более понятное название. А то тут уже задумываешься, что за копия?

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и почему не reduce?

lego.js

return copy.map(function (entry) {

return selectByParam(params, entry);

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если в функции только return можно не отделять его пустой строкой

lego.js Outdated

var params = [].slice.call(arguments);

return function select(collection) {

var copy = collection.slice();

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже давай поменяем название

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

или дополним его

lego.js Outdated

* @param {String} order – Порядок сортировки (asc - по возрастанию; desc – по убыванию)

function checkPropAndValues(entry, property, values) {

for (var i = 0; i < values.length; i++) {

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно методом массивов some воспользоваться. Кажется будет короче

lego.js

return copy.sort(function (entryOne, entryTwo) {

if (order === 'asc') {

return entryOne[property] > entryTwo[property];

@Lakate Lakate Nov 1, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже можно не отделять последней строкой

Lakate commented Nov 1, 2016

Copy link

Copy Markdown

Глеб, ты молодец!
поправляй замечания и отдадим тебя ментору

Lakate commented Nov 1, 2016

Copy link

Copy Markdown

🍅

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

@Lakate обрати внимание решено доп. задание

Lakate commented Nov 2, 2016

Copy link

Copy Markdown

написала в личку

Lakate commented Nov 2, 2016

Copy link

Copy Markdown

🍅


 расставил файлы по местам

46ff63b

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

@Lakate обрати внимание решено доп. задание

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Nov 2, 2016

Copy link

Copy Markdown

@Lakate обрати внимание решено доп. задание

Lakate commented Nov 2, 2016

Copy link

Copy Markdown

Молодец!
🚀

@honest-hrundel honest-hrundel assigned meded90 and unassigned Lakate

Nov 2, 2016

@gogoleff gogoleff unassigned meded90

Nov 2, 2016

@gogoleff

gogoleff commented Nov 2, 2016

Copy link

Copy Markdown

Contributor

🚀

@honest-hrundel honest-hrundel assigned meded90

Nov 2, 2016

meded90

meded90 reviewed

Nov 9, 2016

View reviewed changes

lego.js Outdated

function selectByParam(params, entry) {

var keys = Object.keys(entry);

var newEntry = {};

keys.forEach(function (key) {

@meded90 meded90 Nov 9, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может лутьше по параметрам будем пробигать их в любом случии меньше

@meded90 meded90 Nov 9, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тогда и иф можно будет убрать

meded90

meded90 reviewed

Nov 9, 2016

View reviewed changes

lego.js Outdated

return;

return function format(collection) {

var copyOfCollection = collection.slice();

@meded90 meded90 Nov 9, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

каждый раз копировать колецию не нужно
темболее мап вернет новый масив

@meded90 meded90 Nov 9, 2016

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже самое везде

@meded90

meded90 commented Nov 9, 2016

Copy link

Copy Markdown

🍅 впринцепе хорошо в 2 местах не рационально и все


 первое исправление

37b96ed

@Zeace Zeace force-pushed the master branch from c7bf17a to 37b96ed Compare

November 10, 2016 05:06

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

🍅 Пройдено тестов 17 из 18


 +проверка

d3fefa6

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

@meded90 обрати внимание решено доп. задание


 убрал копирование в местах использования map

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

@meded90 обрати внимание решено доп. задание


 избавился от ненужных копий

6ba6d52

honest-hrundel commented Nov 10, 2016

Copy link

Copy Markdown

🍏 Пройдено тестов 18 из 18