Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Заморский Глеб#15

Closed
Zeace wants to merge 6 commits into
urfu-2016:master from
Zeace:master
Closed

Заморский Глеб #15
Zeace wants to merge 6 commits into
urfu-2016:master from
Zeace:master

Conversation

@Zeace

@Zeace Zeace commented Oct 30, 2016

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@Lakate обрати внимание решено доп. задание

Comment thread lego.js
function sortByPriority(a, b) {
var priority = ['filterIn', 'and', 'or', 'sortBy', 'select', 'limit', 'format'];

return priority.indexOf(b.name) < priority.indexOf(a.name);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lego.js Outdated
var operators = [].slice.call(arguments, 1);
operators.sort(sortByPriority);
for (var i = 0; i < operators.length; i++) {
copy = operators[i](copy);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давай дадим более понятное название. А то тут уже задумываешься, что за копия?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и почему не reduce?

Comment thread lego.js

return copy.map(function (entry) {

return selectByParam(params, entry);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

если в функции только return можно не отделять его пустой строкой

Comment thread lego.js Outdated
var params = [].slice.call(arguments);

return function select(collection) {
var copy = collection.slice();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже давай поменяем название

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

или дополним его

Comment thread lego.js Outdated
* @param {String} order – Порядок сортировки (asc - по возрастанию; desc – по убыванию)
*/
function checkPropAndValues(entry, property, values) {
for (var i = 0; i < values.length; i++) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

можно методом массивов some воспользоваться. Кажется будет короче

Comment thread lego.js
return copy.sort(function (entryOne, entryTwo) {
if (order === 'asc') {

return entryOne[property] > entryTwo[property];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тут тоже можно не отделять последней строкой

Lakate commented Nov 1, 2016

Copy link
Copy Markdown

Глеб, ты молодец!
поправляй замечания и отдадим тебя ментору

Lakate commented Nov 1, 2016

Copy link
Copy Markdown

🍅

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@Lakate обрати внимание решено доп. задание

Lakate commented Nov 2, 2016

Copy link
Copy Markdown

написала в личку

Lakate commented Nov 2, 2016

Copy link
Copy Markdown

🍅

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@Lakate обрати внимание решено доп. задание

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@Lakate обрати внимание решено доп. задание

Lakate commented Nov 2, 2016

Copy link
Copy Markdown

Молодец!
🚀

gogoleff commented Nov 2, 2016

Copy link
Copy Markdown
Contributor

🚀

Comment thread lego.js Outdated
function selectByParam(params, entry) {
var keys = Object.keys(entry);
var newEntry = {};
keys.forEach(function (key) {

@meded90 meded90 Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может лутьше по параметрам будем пробигать их в любом случии меньше

@meded90 meded90 Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тогда и иф можно будет убрать

Comment thread lego.js Outdated

return;
return function format(collection) {
var copyOfCollection = collection.slice();

@meded90 meded90 Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

каждый раз копировать колецию не нужно
темболее мап вернет новый масив

@meded90 meded90 Nov 9, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

тоже самое везде

meded90 commented Nov 9, 2016

Copy link
Copy Markdown

🍅 впринцепе хорошо в 2 местах не рационально и все

Copy link
Copy Markdown

🍅 Пройдено тестов 17 из 18

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@meded90 обрати внимание решено доп. задание

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@meded90 обрати внимание решено доп. задание

Copy link
Copy Markdown

🍏 Пройдено тестов 18 из 18

Copy link
Copy Markdown

@meded90 обрати внимание решено доп. задание

meded90 commented Nov 10, 2016

Copy link
Copy Markdown

🍏 гуд

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@meded90 meded90 meded90 left review comments
@Lakate Lakate Lakate left review comments
Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /