Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix #1141 - L1 spawn issues#1143

Open
shawntobin wants to merge 1 commit into
master from
st/l1-spawn-fix
Open

Fix #1141 - L1 spawn issues #1143
shawntobin wants to merge 1 commit into
master from
st/l1-spawn-fix

Conversation

@shawntobin

@shawntobin shawntobin commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Closes Address shows no Urbit IDs after L1 planet spawn to own address #1141
  • The call to the roller was throwing an error for a newly spawned L1 point since it didn't yet know it existed. The try / catch block wasn't set up in a way to properly handle the error, so it wasn't checking the chain when the point couldn't be found in roller state.
  • This fix checks the chain when the roller doesn't return the point, and if it exists then it returns the point using on-chain data.
 

The roller call was throwing an error for newly spawned L1 planets since it couldn't find them in state yet.

Copy link
Copy Markdown
Member

Thanks for looking into this. Looks like the right solution to me but will defer to @pkova to review/merge/deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkova pkova Awaiting requested review from pkova

@polwex polwex Awaiting requested review from polwex

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address shows no Urbit IDs after L1 planet spawn to own address

AltStyle によって変換されたページ (->オリジナル) /