-
Notifications
You must be signed in to change notification settings - Fork 28
Open
Conversation
@jalehman
jalehman
requested review from
pkova and
shawntobin
and removed request for
tomholford
September 8, 2023 15:28
@shawntobin
shawntobin
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tested locally with no issues. A couple minor notes:
- Typo in the filename "usetSetNetworkKeys.ts"
- We changed the waitMessage text since this PR, so that should probably be updated in this new FactoryReset component.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates flow for factory reset AKA breach.
closes #1046
Screenshot 2023年07月14日 at 7 36 58 PM Screenshot 2023年07月14日 at 7 37 07 PM Screenshot 2023年07月14日 at 7 37 02 PM