-
Notifications
You must be signed in to change notification settings - Fork 143
fix(cli): handle dot input and validate npm package names#41
Open
ProdigyRahul wants to merge 1 commit intoupstash:main from
Open
fix(cli): handle dot input and validate npm package names #41ProdigyRahul wants to merge 1 commit intoupstash:main from
ProdigyRahul wants to merge 1 commit intoupstash:main from
Conversation
Author
I've submitted a PR to a public open-source repo. Hoping they merge it. >_< @joschan21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
image
added:
// NPM package name validation regex
const VALID_PACKAGE_NAME = /^(?:(?:@(?:[a-z0-9-
(削除) ][a-z0-9-. (削除ここまで)])?/)?[a-z0-9-._~][a-z0-9-(削除) ]|[a-z0-9- (削除ここまで)])$/// Function to sanitize package name
const sanitizePackageName = (name: string): string => {
return name
.toLowerCase()
.replace(/[^a-z0-9-~]/g, '-')
.replace(/^[._]/, '')
.replace(/^-+|-+$/g, '')
|| 'jstack-app'
}
and also added this validation:
// Handle "." input by using current directory name
if (value === ".") {
const currentDir = path.basename(process.cwd())
value = currentDir
}