Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

test: failing tests — inline direction from ancestor is ignored by rtl:/ltr: variants#576

Closed
istarkov wants to merge 1 commit into
uni-stack:main from
istarkov:test/rtl-inherited-from-ancestor
Closed

test: failing tests — inline direction from ancestor is ignored by rtl:/ltr: variants #576
istarkov wants to merge 1 commit into
uni-stack:main from
istarkov:test/rtl-inherited-from-ancestor

Conversation

@istarkov

@istarkov istarkov commented Jun 10, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Failing tests showing that rtl:/ltr: variants ignore direction set on an ancestor (validateDir only checks the component's own props.style).

Follow-up to #574 (comment) — proves #573 is not fixed.

Summary by CodeRabbit

  • Tests
    • Added test coverage for directional styling inheritance, verifying that direction-specific utility classes are properly resolved when inherited from parent elements.

coderabbitai Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

i️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d48b49d-2637-4383-b171-3954ea7c77b5

📥 Commits

Reviewing files that changed from the base of the PR and between 0a50373 and 82e846b.

📒 Files selected for processing (1)
  • packages/uniwind/tests/native/styles-parsing/dir.test.tsx
📝 Walkthrough

Walkthrough

This PR adds two test cases to the Dir test suite that verify direction-specific utility classes (rtl: and ltr:) are correctly resolved when an element inherits the direction style from an ancestor View component with an explicit inline style.

Changes

Direction Inheritance Test Coverage

Layer / File(s) Summary
RTL/LTR inherited direction test cases
packages/uniwind/tests/native/styles-parsing/dir.test.tsx		 Two new "inline ... inherited from ancestor" tests render a parent View with direction set and assert the child's rtl: and ltr: classes produce the expected backgroundColor matching TW_RED_500.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • uni-stack/uniwind#574: Implements the RTL/LTR dir resolution behavior that these tests validate, including ancestor-inherited direction handling via inline style props.

Poem

🐰 Direction now flows through the family tree,
rtl: and ltr: inherit wild and free,
Tests confirm what grandparents bestow,
Styles cascade where directions go! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the purpose of the pull request: adding failing tests to demonstrate that rtl:/ltr: variants ignore inherited direction from ancestor elements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /