-
Notifications
You must be signed in to change notification settings - Fork 570
Add missing return statement to copyToClipboard util #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using the `useCopyToClipboard` I noticed that the 2nd argument returned by the hook (the `copyToClipboard` callback) does not match the typescript signature.
Hey @tylermcginnis can you have a quick 👀 please?
Update:
Sorry for the causal message 😅 (it didn't dawn on me that it might be a bit rude and a bit too direct), would appreciate your help here! 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
While using the
useCopyToClipboardhook I noticed that the 2nd argument returned by the hook (thecopyToClipboardcallback) does not match the typescript signature.usehooks/index.d.ts
Lines 126 to 129 in 945436d
By adding a
imagereturnbefore thehandleCopyfunction call, the callback now returns the promise, which now allows you to chain a.then()and.catch()to it, while previously it used to throw