This repository was archived by the owner on Jun 27, 2025. It is now read-only.
forked from stephan-hof/pyrocksdb
-
Notifications
You must be signed in to change notification settings - Fork 91
Open
Conversation
nitoqq
commented
Mar 4, 2019
Author
Hi, what do you think of this PR?
kataev
commented
Jun 21, 2019
🐥🐥🐥
@nitoqq
nitoqq
force-pushed
the
add-create-missing-column-families-option
branch
from
December 10, 2020 12:12
f9225d3 to
ea96bc7
Compare
iFA88
iFA88
suggested changes
Mar 9, 2021
@iFA88
iFA88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need declare this also in options.pxd:
cdef cppclass DBOptions:
...
cpp_bool create_missing_column_families
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added descriptor for
create_missing_column_familiesdb option