-
Notifications
You must be signed in to change notification settings - Fork 578
add pvp versionScheme to project POMs#311
Open
bpholt wants to merge 1 commit intotwitter:develop from
Open
Conversation
PVP is described as a version scheme in which "X.Y are treated as [the] major version," which I think accurately describes the version scheme of this library. (More information about versionScheme is available at https://www.scala-sbt.org/1.x/docs/Publishing.html#Version+scheme)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PVP is described by sbt as a version scheme in which "X.Y are treated as [the] major version," which I think accurately describes the version scheme of this library. Adding this setting to a library's POM will help sbt manage evictions and transitive dependencies, and should help avoid binary incompatibilities. (See "Preventing Version Conflicts with versionScheme" and the sbt documentation for more details.)
If this change is accepted, I'm happy to make similar PRs to finagle and scrooge.