-
Notifications
You must be signed in to change notification settings - Fork 578
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #308 +/- ## ======================================== Coverage 49.11% 49.12% ======================================== Files 320 320 Lines 18459 18459 Branches 1074 1074 ======================================== + Hits 9067 9068 +1 + Misses 9392 9391 -1
Continue to review full report at Codecov.
|
felixbr
commented
Jul 28, 2022
Ok, so apart from the usual flaky test in util-app everything seems to be working decently.
I've downgraded sbt-scoverage to 1.9.1 though, because develop is currently not green.
I'm rebasing this onto develop to make it ready for merging, even if it means the CI will be red on this PR in the meantime. 🙂
a15bd27 to
c8f2c66
Compare
bryce-anderson
commented
Jul 28, 2022
@felixbr, do you mind rebasing on master to get the scoverage fix pulled in and presumably turn the CI checks green?
c8f2c66 to
92b8e73
Compare
@bryce-anderson There you go.
The one failing test is the usual flaky one in util-app. I'd recommend setting its timeout much higher because it's really annoying that PRs are red all the time because of it.
It's waiting for an interrupt but CI is too slow so instead it throws a timeout:
[info] - App: exit functions properly capture mix of non-fatal and fatal exceptions *** FAILED ***
[info] class com.twitter.util.TimeoutException did not equal class java.lang.InterruptedException (AppTest.scala:418)
92b8e73 to
e42dbe2
Compare
e42dbe2 to
eb9d2f6
Compare
felixbr
commented
Aug 11, 2022
I rebased the PR onto develop.
eb9d2f6 to
9ab3aca
Compare
felixbr
commented
May 18, 2023
I rebased the PR onto develop.
The two failed runs are the usual flaky test in util-app (see #310)
rbscgh
commented
Jan 27, 2025
can we bump this to a LTS version of 3 like 3.3.4 ?
felixbr
commented
Jan 29, 2025
@rbscgh We could, but I think it's fair to say Twitter (or whatever is left of it) has given up on open source contributions.
Until I see a clear indication to the contrary I won't waste more time on this.
That said, if there's a community fork let me know and I'll gladly help out.
Several people have worked on Scala 3 support of various modules, which is great.
Scala 3 support currently isn't part of CI, which means it is only validated locally by the person currently working on it. This causes already working cross-builds to break by accident (e.g. when updating versions).
To avoid this and make working on Scala 3 more efficient I'm trying to setup at least basic CI for it.
Coverage is currently not really working with Scala 3.0.2, so I'm trying to ignore it for Scala 3 only.