-
Notifications
You must be signed in to change notification settings - Fork 770
When plot = FALSE, don't call plot.new #61
When plot = FALSE, don't call plot.new #61
Conversation
plot.new() is generally unfriendly to call unless it will actually be used for drawing, and certainly not if we ask for no plots to be created. plot.new triggers the completion of the previous plotting action, and as such can't be used in combination with any multithreading or forked R processes. plot.new also does not return a "plot" object, it always returns `NULL`, so although it appears to be used here as a way of returning a "null plot", all that really happens is that AnomalyDetection* returns `list(..., plot = NULL)`. This commit resolves twitter#60
jhochenbaum
commented
Oct 7, 2015
Thanks @jcpetkovich !
akejariwal
commented
Oct 7, 2015
@caniszczyk The PR looks good. Please merge.
jcpetkovich
commented
Nov 18, 2015
Anything holding this back from a merge?
wlopata
commented
Feb 10, 2016
Ping! Just hit into this issue myself.
trh178
commented
Mar 4, 2016
Also just hit the issue. Does anyone else have write access to perform the merge?
gonzalodiaz
commented
May 16, 2016
+1 to this change. I was about to do the same.
dmpe
commented
May 21, 2016
/cc @caniszczyk
Winterflower
commented
Jul 4, 2017
+1 for this change - please let me know if I can help in any way to get this merged into the codebase. I'm hitting this issue when trying to run AnomalyDetectionTs in a subprocess.
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
plot.new() is generally unfriendly to call unless it will actually be
used for drawing, and certainly not if we ask for no plots to be
created.
plot.new triggers the completion of the previous plotting action, and as
such can't be used in combination with any multithreading or forked R
processes.
plot.new also does not return a "plot" object, it always returns
NULL,so although it appears to be used here as a way of returning a "null
plot", all that really happens is that AnomalyDetection* returns
list(..., plot = NULL).This commit resolves #60