-
Notifications
You must be signed in to change notification settings - Fork 166
Comments
Invert NOB_STRIP_PREFIX and NOB_STRIP_PREFIX_GUARD_ checks#125
Open
minefreak19 wants to merge 1 commit intotsoding:main from
Open
Invert NOB_STRIP_PREFIX and NOB_STRIP_PREFIX_GUARD_ checks #125minefreak19 wants to merge 1 commit intotsoding:main from
NOB_STRIP_PREFIX and NOB_STRIP_PREFIX_GUARD_ checks #125minefreak19 wants to merge 1 commit intotsoding:main from
Conversation
This way, NOB_STRIP_PREFIX_GUARD_ is not defined until the prefixes are actually stripped, so a header file can simply `#include "nob.h"` without polluting the namespace while the corresponding C file can `#define NOB_STRIP_PREFIX` and re-include nob.h to use the short names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, NOB_STRIP_PREFIX_GUARD_ is not defined until the prefixes are actually stripped, so a header file can simply
#include "nob.h"without polluting the namespace while the corresponding C file can#define NOB_STRIP_PREFIXand re-include nob.h to use the short names.