-
Notifications
You must be signed in to change notification settings - Fork 72
Support Kotlin 1.9.0 #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Kotlin 1.9.0 #388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JS compiler calls .canonicalFile internally - at least on MacOS that may be different to the absolute path (/private/var/... vs /var/...), which made the tests fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useDeprecatedLegacyCompiler was removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR can we remove the call in KotlinCompilation for setting useIR as it is defaulted to true and is removed by Kotlin 1.9.20-Beta2 so this would just be another breaking change coming soon.
@apatrida I've just pushed a commit to remove useIR. I've also updated to Kotlin 1.9.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in this commit.
A follow-up to #380 (and closes #379).
Let's see if I have better luck with Windows tests.