Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

dijkstra algo fixed ,duplicate files removed #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahul4581 wants to merge 1 commit into trekhleb:master
base: master
Choose a base branch
Loading
from rahul4581:dijkstra-algo-fix

Conversation

Copy link

@rahul4581 rahul4581 commented Aug 1, 2025

Solved #2056
📝 Summary
This PR improves the Dijkstra algorithm implementation to ensure correct handling of priority updates for neighbors in the priority queue

🧠 Problem
In the current implementation, the neighbor’s priority in the queue is only updated if queue.hasValue(neighbor) returns true. This is logically sound only if the PriorityQueue:

Correctly changes the priority of an existing node, and

Does not contain duplicate entries.

If the PriorityQueue does not update priorities properly or allows duplicates, a node may exist multiple times in the queue with different costs — potentially breaking Dijkstra's guarantees.

✅ Fix
Explicitly ensure priority updates are handled correctly even if the node is already present in the queue.

Avoid potential issues caused by multiple entries of the same node with different priorities.

Copy link

Was it that hard writing it on your own?

Copy link
Author

just trying to contribute in open source projects @lazarljubenovic bro

Copy link

Huh, looks like it is hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /