-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
dijkstra algo fixed ,duplicate files removed #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazarljubenovic
commented
Aug 1, 2025
Was it that hard writing it on your own?
just trying to contribute in open source projects @lazarljubenovic bro
lazarljubenovic
commented
Aug 2, 2025
Huh, looks like it is hard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #2056
📝 Summary
This PR improves the Dijkstra algorithm implementation to ensure correct handling of priority updates for neighbors in the priority queue
🧠 Problem
In the current implementation, the neighbor’s priority in the queue is only updated if queue.hasValue(neighbor) returns true. This is logically sound only if the PriorityQueue:
Correctly changes the priority of an existing node, and
Does not contain duplicate entries.
If the PriorityQueue does not update priorities properly or allows duplicates, a node may exist multiple times in the queue with different costs — potentially breaking Dijkstra's guarantees.
✅ Fix
Explicitly ensure priority updates are handled correctly even if the node is already present in the queue.
Avoid potential issues caused by multiple entries of the same node with different priorities.