-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
Update CONTRIBUTING.md #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Update CONTRIBUTING.md #1457
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
31 changes: 12 additions & 19 deletions
CONTRIBUTING.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,18 @@ | ||
## Contributing | ||
## 🌟 Contributing | ||
|
||
**General Rules** | ||
### 📜 General Rules | ||
|
||
- As much as possible, try to follow the existing format of markdown and code. | ||
- Don't forget to run `npm run lint` and `npm test` before submitting pull requests. | ||
- Make sure that **100%** of your code is covered by tests. | ||
- 🖋️ Follow the existing format of markdown and code as much as possible. | ||
- 🔍 Run `npm run lint` and `npm test` before submitting your pull request. | ||
- ✅ Ensure **100%** of your code is covered by tests. | ||
|
||
**Contributing New Translation** | ||
### 🌍 Contributing a New Translation | ||
|
||
- Create new `README.xx-XX.md` file with translation alongside with | ||
main `README.md` file where `xx-XX` is [locale and country/region codes](http://www.lingoes.net/en/translator/langcode.htm). | ||
For example `en-US`, `zh-CN`, `zh-TW`, `ko-KR` etc. | ||
- You may also translate all other sub-folders by creating | ||
related `README.xx-XX.md` files in each of them. | ||
- 📄 Create a new `README.xx-XX.md` file for your translation alongside the main `README.md`. Use [locale and country/region codes](http://www.lingoes.net/en/translator/langcode.htm) for naming (`xx-XX`), like `en-US`, `zh-CN`, `ko-KR`, etc. | ||
- 📁 Translate any relevant sub-folders by creating `README.xx-XX.md` files in each. | ||
|
||
**Contributing New Algorithms** | ||
### 📐 Contributing a New Algorithm | ||
|
||
- Make your pull requests to be **specific** and **focused**. Instead of | ||
contributing "several sorting algorithms" all at once contribute them all | ||
one by one separately (i.e. one pull request for "Quick Sort", another one | ||
for "Heap Sort" and so on). | ||
- Provide **README.md** for each of the algorithms **with explanations** of | ||
the algorithm and **with links** to further readings. | ||
- Describe what you do in code using **comments**. | ||
- 🎯 Keep pull requests **specific** and **focused**. For example, rather than submitting "several sorting algorithms," submit them individually, such as one PR for "Quick Sort" and another for "Heap Sort." | ||
- 📝 Include a **README.md** file for each algorithm with a **detailed explanation** and **links to additional resources**. | ||
- 💬 Use **comments** in your code to describe each step and clarify your logic. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.