-
Notifications
You must be signed in to change notification settings - Fork 78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update; I left one inline suggestion in foundations/whitepapers/ton.mdx: please apply the inline suggestion to align with the style guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed TON whitepaper updates. In foundations/whitepapers/ton.mdx I have several suggestions around anchors, cross-references, and wording—please apply the inline suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Malformed TON Storage anchor slug
The TON Storage bullet now links to #4-1-8-example:-keeping-files-off-chain;-ton-storage, which includes a colon and semicolon in the slug. The referenced heading is #### 4.1.8. Example: keeping files off-chain; TON Storage, whose generated ID under common slug rules will drop punctuation characters, yielding a form like 4-1-8-example-keeping-files-off-chain-ton-storage. Because the link slug retains punctuation that is not present in the heading ID, it is at high risk of not matching the actual anchor. This breaks intra-page navigation from the top-level description of TON components to the detailed TON Storage section.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Malformed TON DHT and related internal links
The TON DHT bullet line currently has a malformed Markdown link and several brittle anchor slugs. The first link is [Kademlia-like distributed hash table](#3-2-ton-dht%3A-kademlia-like-distributed-hash-table (*TON DHT*), ... which is missing a closing parenthesis for the link and thereby breaks the Markdown structure for the entire line. In addition, the slug uses a percent-encoded colon (%3A) and the nested links for "torrent trackers" and "network interest groups" use curly-quoted, punctuation-heavy slugs; these do not cleanly correspond to the section headings such as #### 3.2.10. Distributed "torrent trackers" and "network interest groups" in TON DHT, whose IDs are normally normalized to plain ASCII text (for example, 3-2-10-distributed-torrent-trackers-and-network-interest-groups-in-ton-dht). As written, this line both breaks rendering and likely produces non-functional anchors for several core DHT sections.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Escaped footnote <sup> markup
The sentence introducing dependent sums ends with \\<sup>[[16]](#references)</sup>, where the leading < is escaped. This causes the superscript footnote reference to render as literal text instead of HTML/MDX markup. The regression appears only in the modified line and disrupts the reference to the Homotopy Type Theory source in a definitional equation.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Incorrect TL constructor anchor slug
In the description of the TVM value format, the link on "constructor" uses the anchor #2-2-5-tl,-or-the-type-language, inserting a comma into the slug. Elsewhere in the document, references to the same section use the canonical #2-2-5-tl-or-the-type-language form, so this variant is inconsistent and likely does not match the actual heading ID. This inconsistency can break navigation in a core explanation of value representation.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Missing closing parenthesis in shard state notation
The equation for ShardchainState is followed by a sentence ending in $(w,s)., i.e., ... [state of shard](#2-1-8-identification-of-shardchains) $(w,s).. This leaves the math expression with an unbalanced opening parenthesis, which is a regression from $(w,s)$ in the base version. The mismatch harms readability of the formal shard identifier notation in a definitional section.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Truncated "tightly-coupled" sharding sentence
In the discussion of sharding support, the sentence ends with the blockchain project needs to be [tightly-coupled](#2-8-14-interaction-between-blockchains%3A-loosely-coupled-and-tightly-coupled-systems) in the sense.. The phrase "in the sense" is left hanging without specifying what it refers to, unlike the base text which explicitly ties the sense to section 2.8.14. This truncation makes the requirement less clear in an important conceptual passage.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Broken overlay network link syntax
The sentence about populating the neighbor list reads with respect to the [overlay network(#3-3-2-overlay-networks-in-ton), ..., placing the anchor parentheses inside the link text and omitting the closing ] before the (. This malformed link breaks the reference to section 3.3.2 and degrades readability in the description of joining overlay networks.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Footnotes block desynchronized from in-text references
The entire ## Footnotes block has been rewritten to use new ids (fn1, fn2, ..., fn17, fn30, fn37) and "Back ↑" links that point to #ref-fnN, while many in-text references still use <a id="ref-fnN"></a><sup>[N](#fnN)</sup> patterns for values of N (e.g., 20) that no longer have corresponding <span id="fnN"> entries. For instance, the validator key sentence at line 917 links to #fn20, but there is no <span id="fn20"> in the new block, making that footnote anchor broken. This desynchronization affects multiple references and violates the internal consistency of cross-references throughout the document.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] Missing back-reference anchors for several footnotes
The footnote section at the end of the file now uses [Back ↑](#ref-fnX) links for many entries (for example, fn1, fn2, ..., fn7, and fn30 at lines 2297–2331), but in the body of the document only some corresponding id="ref-fnX" anchors have been introduced. For instance, the main text at line 69 still has <sup>[1](#fn1)</sup> with no preceding <a id="ref-fn1"></a>, while other notes such as fn10–fn17 and fn37 do have matching ref-fn10–ref-fn17/ref-fn37 anchors in the body (e.g., lines 493, 537, 563, 654–692, 706–708, 788, 796, and 2152). This partial migration leaves several "Back ↑" links pointing at non-existent IDs, creating broken in-page navigation for readers trying to return from the footnotes to their call sites—a class of errors that your style guide classifies as HIGH severity.
Please leave a reaction 👍/👎 to this suggestion to improve future reviews for everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links to EOS and PolkaDot are correct but don't navigate to the exact section when clicked. This is because the EOS and PolkaDot headings contain URLs in the heading text itself, I think this should be checked out
reveloper
commented
Dec 23, 2025
1st Chapter ok.
Uh oh!
There was an error while loading. Please reload this page.
Closes #1393