-
Notifications
You must be signed in to change notification settings - Fork 156
Open
Conversation
@evandcoleman
evandcoleman
force-pushed
the
allow-specify-authors
branch
from
February 24, 2019 18:16
b48bc87 to
e1390a8
Compare
@evandcoleman
evandcoleman
force-pushed
the
allow-specify-authors
branch
from
February 24, 2019 18:16
e1390a8 to
a6122a5
Compare
tomgi
commented
Mar 7, 2019
Owner
Hi @edc1591, thank you for submitting that improvement!
I think you should add this new optional parameter to https://github.com/tomgi/git_stats/blob/master/lib/git_stats/cli.rb to allow the list of emails to be provided when invoking the app.
Could you also add some tests for this new behavior?
Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to limit stats to specific email addresses to decrease the time it takes to generate stats.