-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Conversation
@github-actions
github-actions
Bot
added
answer
answer
contributor
highly contributing to the project
to be reviewed
PR requests a review
64
labels
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have provided 2 different approaches to resolve this challenge.
The first one is based on
FormValueControlto build the form elements and the second one uses aFieldTreetyped signal input.By using the
FormValueControlI was forced to add a lot of boilerplate code to handle each element's touched, dirty states.In addition, touched and dirty events are not triggered properly at the fieldTree level, so I added 2 more optional inputs to the
app-validationcomponent to show the errors correctly thus poluting the component's API significantly.On the contrary, by using the input approach the code looks a way more cleaner and declarative.