-
Notifications
You must be signed in to change notification settings - Fork 11
Add a flag to skip .so file strip. #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks a lot @blimmer! I made one small comment, could you please check?
Hey @tobilg - no problem. I don't see any comments on the files or the commit. Could you point me in the right direction? I'm happy to take a look.
tobilg
tobilg
reviewed
May 27, 2020
@blimmer sorry, this somehow got stuck in the GitHub App
This allows dependencies with compiled binaries, such as psycopg2-binary to work properly in the Lambda environment after building.
@blimmer
blimmer
force-pushed
the
add-flag-to-strip-so-strip
branch
from
May 27, 2020 18:51
b24d884 to
175a1eb
Compare
No problem! Update made.
tobilg
tobilg
approved these changes
May 27, 2020
Thanks a lot @blimmer!
No problem - thanks for the fast review and, more generally, this project!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dependencies with compiled binaries, such as psycopg2-binary to work properly in the Lambda environment after building.
When the
.sofiles are stripped, the Lambda function will fail with this exception:I've tested this change on my project and can confirm that it works as expected for my project.
I came to this conclusion by taking a look at serverless-python-requirements which provides this option and specifically mentions the
ELF load commanderror I was receiving: https://github.com/UnitedIncome/serverless-python-requirements#option-not-to-strip-binariesAlso, thank you for this project! It has been very useful 😄