-
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: add proxy support #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the -x shorthand is taken from cURL (or similar)? 👀 Do we want to leave that reserved in case something is added in future with that shorthand in the client spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I actually borrowed that from how cURL uses it for proxies.
About that client spec reservation point, I wasn't really sure if we had a standard for short flags yet, or if there's one planned. If -x might clash with anything down the line, I'm totally open to changing it!
This PR introduces proxy support for network requests, allowing users to route traffic through a specified proxy server.