-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix #112: Harden credential file permissions across all auto-collec... - #115
Open
mattiagggg wants to merge 1 commit into
Open
Conversation
...o-collectors Add `import os` and `os.chmod(CONFIG_PATH, 0o600)` after each `CONFIG_PATH.write_text(...)` call, and add `mode=0o700` to each `CONFIG_PATH.parent.mkdir(...)` call in the 4 files that have `save_config()`: feishu_auto_collector.py, slack_auto_collector.py, dingtalk_auto_collector.py, and feishu_mcp_client.py. Create `tests/` directory with `tests/test_config_permissions.py` containing a unittest that writes a config via save_config and asserts file mode is 0o600 and dir mode is 0o700 (skipped on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden credential file permissions across all auto-collectors to prevent other users on the system from reading sensitive config files containing API tokens and secrets.
Changes
0o600(owner read/write only) after writing config indingtalk_auto_collector.py,feishu_auto_collector.py,feishu_mcp_client.py, andslack_auto_collector.py0o700(owner only) when creating config parent directoriesCONTRIBUTING.mdTesting
tests/test_config_permissions.pythat callsave_config, then assert file mode is0o600and directory mode is0o700(skipped on non-POSIX systems)save_config()and confirm withls -lathat output files show-rw-------permissionsCloses #112