Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add support for float type #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fkollmann wants to merge 1 commit into timsolov:master
base: master
Choose a base branch
Loading
from smartpricer:master

Conversation

Copy link

@fkollmann fkollmann commented Nov 23, 2021

Adds support for float field type.

myfield:float --> float32

Copy link
Owner

@fkollmann thank you for your PR. Please fix readme file and I'll merge it.

Copy link
Author

@timsolov Can you elaborate on "fix readme"? From my POV the readme was updated. What needs to be changed from your POV?

Copy link
Owner

I don't see any changes in README it also contain float - integer type. . But also from my POV as in Go we don't have simple float type (like int for integers) we've to use here explicitly type like float32 or float64 and have to support both.

Copy link

@timsolov Is it possible to merge this PR? If possible I can fix the rest of the missing features for float32 and float64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /