-
Notifications
You must be signed in to change notification settings - Fork 56
Comments
Remove JS Doc comments that blow up in TypeScript 2.9 from index.js#57
Open
davidjpfeiffer wants to merge 1 commit intotimoxley:master from
Open
Remove JS Doc comments that blow up in TypeScript 2.9 from index.js #57davidjpfeiffer wants to merge 1 commit intotimoxley:master from
davidjpfeiffer wants to merge 1 commit intotimoxley:master from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These JS Doc comments are causing my Angular production build to fail because my production build includes this code (this package is a dependency of a dependency of mine that is needed at compile time) and this code does not compile due to a bug in TypeScript version 2.9.
To resolve the issue, I have a custom script that removes the comments from this file so that my production build will pass. I would very much appreciate it if you would merge this PR and publish the changes on NPM so that I do not need to do this hacky thing during my deployments. I know that other people are having this same problem (even though I'm a bit late to the party).
If you want to keep these comments, can you please put them into a format that will compile for all TypeScript versions? It would be very much appreciated.